Freeze 1.6.0, introduce 1.7.0 (as dev) #415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
freeze_1p6p0
branch
4 times, most recently
from
82f353b
to
6e46c62
Compare
This was referenced Dec 12, 2023
Merged
braingram
force-pushed
the
freeze_1p6p0
branch
from
c08271f
to
26ffa32
Compare
braingram
changed the title
braingram
dismissed
eslavich’s stale review
Major changes were made to this PR and it is now not ready for review.
|
@eslavich I dismissed your review here to not give the impression that the current state of this PR is approved. The current PR is quite different from the one you reviewed for a few reasons:
Thanks for giving this a look and I believe the above changes are still work doing (especially the new manifest extension schema). I just think they will require more extensive changes that will span multiple PRs. |
|
Superseded by: #422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: this PR was too ambitious and has been simplified (removing the semantic versioning change) and now includes only the freezing of 1.6.0 and introduction of 1.7.0 (as the new development version).
I am leaving this as draft because the release of 1.6.0 will impact a large number of packages. A test PR is open for asdf where the downstream impact is being tested: asdf-format/asdf#1744