Skip to content

Error if version not in MAJOR.MINOR.PATCH format #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Error if version not in MAJOR.MINOR.PATCH format #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bin/download
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ download_golang() {
local platform=""
local arch=""

# Validate version format before attempting download
validate_version "$version"

platform=$(get_platform)
arch=$(get_arch)
download_url="https://dl.google.com/go/go${version}.${platform}-${arch}.tar.gz"
Expand Down
10 changes: 10 additions & 0 deletions lib/helpers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ get_arch() {
printf "%s" "$arch"
}

validate_version() {
local version="$1"

# Check if version matches the pattern major.minor.patch
# This allows for versions like 1.21.0, 1.22.1, etc.
if [[ ! "$version" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
fail "Invalid version format: '$version'. Go versions must be in the format 'major.minor.patch' (e.g., '1.25.0')."
fi
}

msg() {
echo -e "\033[32m$1\033[39m" >&2
}
Expand Down
Loading