Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic GOPATH settings to zsh and fish #127

Merged
merged 2 commits into from
May 20, 2024

Conversation

leonardobazico
Copy link
Contributor

Fix issue #106 by make GOPATH dynamic based on the asdf golang version.

@leonardobazico leonardobazico requested a review from a team as a code owner October 12, 2023 17:05
Copy link

@carlosvigil carlosvigil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had done the same in my config, but then I realized we should be using asdf reshim go. I don't understand shims so I figured I should avoid setting the GOPATH since the original author opted out. Any insights? Would adding the reshim command be more correct?

@kennyp kennyp merged commit 0e86b1d into asdf-community:master May 20, 2024
3 checks passed
BorzdeG pushed a commit to BorzdeG/asdf-golang that referenced this pull request Jul 28, 2024
Co-authored-by: Kenny Parnell <k.parnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants