[chore] Fix a number of alerts found on LGTM.com #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifying the state object directly is undesirable (see https://lgtm.com/rules/1823611029/).
React component state updates using setState may asynchronously update this.props and this.state, thus it is not safe to use either of the two when calculating the new state passed to setState, and instead the callback-based variant should be used instead.
|
thanks, it's awesome. |
|
Thanks for merging! @ascoders if you like, you can enable automated code review to automatically catch mistakes like this in the future. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a normal feature/bugfix PR, and I'm unsure if this is the sort of contribution you'd like to receive, but thought there's no harm in trying :)
This PR fixes a number of alerts that I found on LGTM.com. The only ones remaining after this are some unused variable alerts.
(Full disclosure: I'm part of the team behind LGTM.com)