Bump JRuby to v9.4.5.0 (fixes #1035) #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
changed the title
abelsromero
force-pushed
the
issue-1035-remove-requires-open-access-messages
branch
from
eedcd73
to
1a9dc3f
Compare
|
@robertpanzer do you see any issue with this? I can merge myself if agree. |
|
Sorry for not being responsive, I am drowning a bit atm :D |
No problem, I was tempted to merge myself seeing all was working fine. But I still like to hear from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
Fix issue #1035 as commented asciidoctor/asciidoctor-maven-plugin#553 (comment)
How does it achieve that?
Yes, validated in maven runs and also building a custom distribution of AsciidoctorJ.
Are there any alternative ways to implement this?
n/a
Are there any implications of this pull request? Anything a user must know?
The only thing is that there's still another warning for Java > 13. But we can treat it in a separated PR.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #1035
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc