Fixes #1221. 'UnsupportedOperationException' when passing immutable Map as options to 'createPhraseNode' #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create mutable copies of options passed to Processor.create...()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create mutable copies of options passed to Processor.create...()
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
Some methods of the Processor API to create nodes mutate the given attributes and options maps.
This is not only surprising, but apparently also fails with an exception if the given map is immutable.
This PR tries to fix this by creating a copy of the given map.
How does it achieve that?
Make a copy of the given map.
Are there any alternative ways to implement this?
I don't think so.
Are there any implications of this pull request? Anything a user must know?
Just in case, it should be impossible to mutate the given options after the Processor was called. This is likely made up, and makes assumptions of the internal behavior of AsciidoctorJ from the users perspective.
Issue
Fixes #1221