Remove deprecated from Document interface #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
issue-1202-remove-deprecated-from-Document-interface
branch
from
f330e68
to
7df16e8
Compare
|
Oops, looks like there is a merge conflict now. Sorry! |
* Improved 'org.asciidoctor.ast.Document' Javadocs Fixes asciidoctor#1202
No problem. Having the guides in partials makes it easy to handle. I'll move your parts to the top and keep that should not interfere with the other branches. |
abelsromero
force-pushed
the
issue-1202-remove-deprecated-from-Document-interface
branch
2 times, most recently
from
751a6eb
to
1d78b5e
Compare
|
Also extracted the text about "removal of |
|
Awesome, thank you! |
abelsromero
deleted the
issue-1202-remove-deprecated-from-Document-interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
Remove deprecated methods from Document interface
Improved 'org.asciidoctor.ast.Document' Javadocs
How does it achieve that?
Simply remove the marked methods and update tests and code accordingly.
Are there any alternative ways to implement this?
No
Are there any implications of this pull request? Anything a user must know?
Users will need to update their code if they use some of the removed methods.
The PR includes a migration guide.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #1202
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc