Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid http://asciidoctor.org references #1196

Conversation

abelsromero
Copy link
Member

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

What is the goal of this pull request?

Fix invalid http://asciidoctor.org references found in docs and JavaDocs.

How does it achieve that?

Are there any alternative ways to implement this?

No.

Are there any implications of this pull request? Anything a user must know?

No.

Issue

Fixes #1195

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

* Applied https where applicable
* Updated JavaDoc references to current links in https://docs.asciidoctor.org/

Fixes asciidoctor#1195
@abelsromero
Copy link
Member Author

kudos @mojavelinux almost all of the old links redirect to the newer equivalent so the changes were trivial 🎉

@mojavelinux
Copy link
Member

That's great to hear! I'd be happy to add any redirects that are missing. Just let me know.

@abelsromero
Copy link
Member Author

That's great to hear! I'd be happy to add any redirects that are missing. Just let me know.

I wouldn't bother, and I went for an as-is update in the PR.
No one else complained about missing redirects, the new site docs.asciidoctor.org is awesome and has been available for years already, and above all, google redirects any "asciidoctor" search to it.

@robertpanzer
Copy link
Member

Thank you so much for this! 🙌

@robertpanzer robertpanzer merged commit db6641e into asciidoctor:main May 4, 2023
@abelsromero abelsromero deleted the issue-1195-fix-invalid-http-asciidoctor-org-references branch May 9, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid 'http://asciidoctor.org' references
3 participants