Deprecate destinationDir option for v2.5.x #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix option to set ToDir internally. Deprecate destinationDir in Options and OptionsBuilder. Add JavaDoc pointing users to use toDir. Fixes asciidoctor#853 Fixes asciidoctor#941
|
Thank you! |
abelsromero
deleted the
issue-853-deprecate-destinationDir-option-for-v2.5.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
Fix the option to set toDir internally.
Deprecate the option to warn users it is being removed in v3.0.x.
How does it achieve that?
Set toDir and add deprecation documentation.
Are there any alternative ways to implement this?
No
Are there any implications of this pull request? Anything a user must know?
No
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #853
Fixes #941
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc