Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upstream test #1123

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

abelsromero
Copy link
Member

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

What is the goal of this pull request?

Fix upstream tests.

How does it achieve that?

Force "-SNAPSHOT" suffix to upstream version
to install gem consistently.
gem-maven-plugin appends it when the gem version
is not strictly semver installing a gem with "-SNAPSHOT"
in the version but not in the maven repo path.

Are there any alternative ways to implement this?

Tried a few things as mentioned here #1121 (comment), option 3 did not work in CI, and this seemed to me the more consistent. We get the sama version format and install path always.

I don't discard spending some extra time with gem-maven-plugin but this depends on time :$

Are there any implications of this pull request? Anything a user must know?

No

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

Force "-SNAPSHOT" suffix to upstream version
to install gem consistently.
gem-maven-plugin appends it when the gem version
is not strictly semver installing a gem with "-SNAPSHOT"
in the version but not in the maven repo path.
@robertpanzer
Copy link
Member

Awesome, thank you, @abelsromero 🚀

@robertpanzer robertpanzer merged commit c137ec5 into asciidoctor:main Oct 12, 2022
@abelsromero abelsromero deleted the fix-upstream-test branch April 22, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants