Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Document::source and Document::source_lines in Document interface #1143

Closed
abelsromero opened this issue Mar 14, 2023 · 1 comment · Fixed by #1145
Closed

Expose Document::source and Document::source_lines in Document interface #1143

abelsromero opened this issue Mar 14, 2023 · 1 comment · Fixed by #1145
Labels
enhancement

Comments

@abelsromero
Copy link
Member

The properties are not exposed and while it can be hacked with ((DocumentImpl)document).getProperty("source") it'd be nice to have them properly exposed.

https://github.com/asciidoctor/asciidoctor/blob/093eed14225bc9ef4664d03fdc965fa7e2acb7a1/lib/asciidoctor/document.rb#L669-L676

For context, this is necessary to access the result of using asciidoctor-reducer.
@abelsromero abelsromero mentioned this issue Mar 14, 2023
Open
2 tasks
@robertpanzer
Copy link
Member

Makes sense. Let's add this property.

@abelsromero abelsromero mentioned this issue Mar 19, 2023
Merged
5 tasks
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Mar 19, 2023
@abelsromero
Expose Document's source and source_lines properties
4d64810 
Fixes asciidoctor#1143
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Mar 19, 2023
@abelsromero
Expose Document's source and source_lines properties
c33af8f 
Fixes asciidoctor#1143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose Document's source and source_lines properties abelsromero/asciidoctorj
2 participants
@robertpanzer @abelsromero