Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TravisCI setting to new vm based builds #377

Merged

Conversation

abelsromero
Copy link
Member

As mentioned here: https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration

Travis is disabling docker model.
This PR just removes configurations that not necessary or working:

  • removes sudo: false
  • removes dist: trusty, which is not needed since trusty is already default

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.101% when pulling 1a0e03e on abelsromero:update_travis_to_new_vm_based_build into c749461 on asciidoctor:master.

@coveralls
Copy link

coveralls commented Nov 20, 2018

Coverage Status

Coverage remained the same at 69.101% when pulling 3705223 on abelsromero:update_travis_to_new_vm_based_build into c749461 on asciidoctor:master.

@mojavelinux
Copy link
Member

I think we should still leave the dist line. While trusty may be the default today, when it becomes not the default, then we could run into a problem. Including it also increases transparency about what the build is actually using.

@abelsromero
Copy link
Member Author

restored

@abelsromero abelsromero merged commit 4765104 into asciidoctor:master Nov 22, 2018
@mojavelinux
Copy link
Member

👍

Btw, if Travis gives other advice about how to use the dist field, then of course we can follow it. Let's keep an eye out for that advice.

@abelsromero abelsromero deleted the update_travis_to_new_vm_based_build branch May 31, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants