Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes #200 - same name for sourceDirectory and outputDirectory X… #202

Merged
merged 1 commit into from
Feb 7, 2016

Conversation

abelsromero
Copy link
Member

This PR includes the correction to the command options configuration and and a new integration test to validate it.

Note: TravisCI adds some Maven configuration that messes with tests that use command line arguments like the one added. To make it work I had to add the export MAVEN_SKIP_RC=true option to the Travis configuration.

…Directory XML and command line arguments
@LightGuard
Copy link
Member

Looks good to me 👍

On Saturday, February 6, 2016, Abel Salgado Romero notifications@github.com
wrote:

This PR includes the correction to the command options configuration and
and a new integration test to validate it.

Note: TravisCI adds some Maven configuration that messes with tests that
use command line arguments like the one added. To make it work I had to add

the export MAVEN_SKIP_RC=true option to the Travis configuration.

You can view, comment on, or merge this pull request online at:

#202
Commit Summary

File Changes

Patch Links:

https://github.com/asciidoctor/asciidoctor-maven-plugin/pull/202.patch


Reply to this email directly or view it on GitHub
#202.

Sent from Gmail Mobile

@mojavelinux
Copy link
Member

👍

This environment environment seems to make builds more isolated, which is a very good thing.

abelsromero added a commit that referenced this pull request Feb 7, 2016
This fixes #200 - same name for sourceDirectory and outputDirectory X…
@abelsromero abelsromero merged commit c227c23 into asciidoctor:master Feb 7, 2016
@abelsromero abelsromero deleted the issue_200 branch September 16, 2017 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants