Added configuration for coveralls.io #143
Conversation
|
Changes Unknown when pulling 721a403 on abelsromero:master into * on asciidoctor:master*. |
| @@ -4,3 +4,6 @@ jdk: | |||
| - oraclejdk7 | |||
| - openjdk7 | |||
| - openjdk6 | |||
| after_success: | |||
| # 'coveralls:report' goal is responsible for updating coverall.io stats once travisCI build completes | |||
| - mvn clean test jacoco:report coveralls:report | |||
There was a problem hiding this comment.
I like the comment.
I have two small change requests.
(1) Can you indent the commented line so that we avoid any YAML parse errors? (Different parsers seem to have different rules, but in general the indentation should match the line it's commenting).
(2) Why are we using after_success? It seems like this will end up running the tests twice. Or is that the intention? I'm thinking more along the lines of:
script:
- mvn clean test jacoco:report
after_success:
# the coveralls:report goal is responsible for updating the coveralls.io stats once the build completes
- mvn coveralls:report
Or is the clean test required when using coveralls? If so, could we just run it all inside a single command in the script:
script:
# the coveralls:report goal is responsible for updating the coveralls.io stats once the build completes
- mvn clean test jacoco:report coveralls:report
Or perhaps the after_success is only run once and not for every time through the matrix. In which case, I see why it is done this way.
There was a problem hiding this comment.
Where is the auth token for coveralls.io stored? Is that an integration Travis provides by default?
|
Changes Unknown when pulling c6b115b on abelsromero:master into * on asciidoctor:master*. |
|
Changes Unknown when pulling c033895 on abelsromero:master into * on asciidoctor:master*. |
|
Changes Unknown when pulling c033895 on abelsromero:master into * on asciidoctor:master*. |
1 similar comment
|
Changes Unknown when pulling c033895 on abelsromero:master into * on asciidoctor:master*. |
|
You were right @mojavelinux, test were executed more than once.
I moved the article from my wiki to https://github.com/asciidoctor/asciidoctor/wiki, I created a new section called Projects manteinance. Let me know it answers your doubt or you see anything wrong. |
That is some seriously good information. Thank you for writing that up! Now we're going to remember how it was setup for sure. Eventually, this page might just become universal information for coveralls.io in the Asciidoctor ecosystem since much of it applies to any repository. We'll update it as needed. What's important is that it exists. |
| @@ -4,3 +4,11 @@ jdk: | |||
| - oraclejdk7 | |||
| - openjdk7 | |||
| - openjdk6 | |||
| install: | |||
| - mvn test-compile -DskipTests=true -Dmaven.javadoc.skip=true -B -V | |||
There was a problem hiding this comment.
Let's use package instead of test-compile for this goal. That ensures we go through the whole cycle at least once (we hit tests in the subsequent steps).
|
I have one minor change request. Then, it looks good to merge! |
|
Changes Unknown when pulling 4ea1615 on abelsromero:master into * on asciidoctor:master*. |
|
I updated (and squashed) the file with the package change. |
|
I'll take a quick peek, then give a thumbs up if all looks good. |
Added configuration for coveralls.io
|
Looks good! I've merged. |
This PR is meant to close the issue #107 adding coverage data with coveralls.io.
For @mojavelinux advise I added a coment on the .travis.yml file and created a wiki page descriving the process.
https://github.com/abelsromero/asciidoctor-maven-plugin/wiki/Coveralls.io-configuration
If everythingt is fine with the document I'll migrate it to the main ascidoctor's wiki.
PS: once is merged I'll edit the badge on the readme.