Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create services interfaces #521

Merged

Conversation

Ayowel
Copy link
Contributor

@Ayowel Ayowel commented Jun 27, 2021

See #519

  • Add unit tests support
  • Add an event service
  • Set explicit component names across the application

The event service has an example use-case to notify of a working directory update across the application and lower coupling (in this case, it drops an explicit dependency to an UI component). I will be using it more as I find other use-cases in the code base, didn't look too much.

This PR also explicitly set components names. This might not seem like much now but it should be a first step toward allowing feature discovery later down the road.

As an aside : I tried to implement a ServiceLoader but was not happy with it as it did not make use of spring features and would just have made the application more bloated. Will give it another go when i find a more fitting design. For now, it feels like autowired components should be configured as attributes instead of being provided in constructor to limit the bloat seen in #272 .

@Ayowel Ayowel mentioned this pull request Jun 27, 2021
13 tasks
@Ayowel Ayowel force-pushed the feature/create-services-interfaces branch from e567d4a to e22e1f2 Compare June 27, 2021 14:30
@rahmanusta rahmanusta changed the base branch from master to development July 15, 2021 14:10
@rahmanusta rahmanusta merged commit 570d0b9 into asciidocfx:development Jul 15, 2021
@rahmanusta
Copy link
Member

Hi, I merged changes to the development branch. We can merge development to master branch before we plan the release.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants