-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github workflow to automatically test PRs and commits on github #520
base: master
Are you sure you want to change the base?
Conversation
Currently we are using travis ci, but we can move to github workflow.
|
Supported, as can be seen in the PR
Should be supported as install4J builds cross-platform. I need to test it though.
Jpackage does not build cross-platform and github does not provide a windows execution environment, so not really an option :/ I had more thought of this as a bonus for development/integration rather than a replacement for travis. Looking at the travis file, what is needed: For maintainance:
For releases:
|
e428954
to
dfb33e2
Compare
@rahmanusta I am at a point where I need a licence key to continue. How do you want to send it ? |
Can you reach me out an email and I’ll send you the license key? My email: rahmanusta@kodedu.com |
Done, The mail's title is
Looks like I lied https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources . Moving to Jpackage might be feasible, albeit somewhat tricky. I probably won't even try. |
92e2896
to
fc33c47
Compare
This should be it. As discussed via mail
ConfigurationCreate an
Additional notes
|
This workflow automatically builds AsciidocFX when a new PR is issued. I added an install4j job but unfortunately could not test it.
I will be adding unit tests when creating future PRs for #519 and thought that having direct feedback on the build's status from within Github without forcing each fork to setup its own CI could prove usefull.
See https://github.com/Ayowel/AsciidocFX/pull and https://github.com/Ayowel/AsciidocFX/actions for a build example