More specific conditional for Node detection #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have been using your library with the Thorax Backbone framework, and last week they updated their package structure to include Backbone using Bower.
Since Thorax has a module 'exports' object but no 'require' function, it would trip the Node conditional on initialize, but fail because the require object doesn't exist. I just made it a little more specific, and it fixed my problem by attaching to the window Backbone object instead of trying to require it in. I hope it jives with you.
Chris