Skip to content

More specific conditional for Node detection #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2013

Conversation

chrisbarless
Copy link

Hi, I have been using your library with the Thorax Backbone framework, and last week they updated their package structure to include Backbone using Bower.

Since Thorax has a module 'exports' object but no 'require' function, it would trip the Node conditional on initialize, but fail because the require object doesn't exist. I just made it a little more specific, and it fixed my problem by attaching to the window Backbone object instead of trying to require it in. I hope it jives with you.

Chris

@asciidisco
Copy link
Owner

Hey, sorry that it took so long to get this in :(
Unfortunately I recently changed jobs & now I have less to no time to take care of this little task anymore.
If anyone is interested in helping out, please ping me, I would love to add you as a maintainer & give you the rights to publish new versions to npm.

asciidisco added a commit that referenced this pull request Oct 10, 2013
More specific conditional for Node detection
@asciidisco asciidisco merged commit 17711b8 into asciidisco:master Oct 10, 2013
@londomloto
Copy link

Using 'override getter' produce 'too much recursion'.
Is there anything I should do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants