Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more tests #106

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Fix more tests #106

merged 3 commits into from
Sep 23, 2021

Conversation

FaceToKeyboard
Copy link
Member

  • StarRating testing better isolated; all passing for now. May want to expand and get more detailed testing later
  • Deleted ProductContext tests - ProductContext is essentially just a direct usage of React's createContext; no longer a fancy component

Copy link
Collaborator

@lrdndy lrdndy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@lrdndy lrdndy merged commit 3d97ca3 into master Sep 23, 2021
@FaceToKeyboard FaceToKeyboard deleted the fixtests branch September 23, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants