Skip to content

Comments

Correct OpenCRG height if reference line has no Z height#72

Open
tbleher wants to merge 1 commit intomasterfrom
refline-no-z-height
Open

Correct OpenCRG height if reference line has no Z height#72
tbleher wants to merge 1 commit intomasterfrom
refline-no-z-height

Conversation

@tbleher
Copy link
Contributor

@tbleher tbleher commented Feb 23, 2026

No description provided.

@tbleher tbleher requested a review from a team February 23, 2026 09:10
@tbleher tbleher added the isState:ReadyforCCBreview CCB will review it and change the status to ReadyForMerge if everything is ok label Feb 23, 2026
@CarawaySeed42
Copy link
Contributor

Is this really correct? The removed branch of the condition is also used if the refline has a constant height (no slope, reference_line_start_z = reference_line_end_z).
By removing the branch the evaluated height will then be offset by reference_line_start_z.

@tbleher
Copy link
Contributor Author

tbleher commented Feb 23, 2026

Is this really correct? The removed branch of the condition is also used if the refline has a constant height (no slope, reference_line_start_z = reference_line_end_z). By removing the branch the evaluated height will then be offset by reference_line_start_z.

I will try to dig up the original context. I have an automated test for this, but will have to see what it tests exactly. This patch has shipped with the Hexagon OdrManager (and thus probably VTD) since sometime in 2020 (I integrated it into our internal toolchain in May 2020).

@MJSommerer Maybe you know some background on this? From our internal commits, I can see that this was tracked at https://redmine.vires.com/issues/10737 but I can't access that site anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isState:ReadyforCCBreview CCB will review it and change the status to ReadyForMerge if everything is ok

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants