Correct curvature check and respect options#32
Open
CarawaySeed42 wants to merge 2 commits intomasterfrom
Open
Conversation
The local curvature check was incorrectly implemented and only worked in certain circumstances. Changes to crg read and write were necessary to properly respect the global curvature check option. The curvature check also did not follow the specification and the specification incorrectly stated the default global curvature options. Resolves: #8 Signed-off-by: Patrick Kuemmerle patrick.kuemmerle@3d-mapping.de
The ok status was always reset even if the local check succeeded. This triggers another unnecessary crg check later. Resolves: #8 Signed-off-by: Patrick Kuemmerle <patrick.kuemmerle@3d-mapping.de>
Contributor
|
Considerations regarding this pull request:
|
3Dbastian
approved these changes
Dec 10, 2025
Contributor
3Dbastian
left a comment
There was a problem hiding this comment.
- in my opinion the local check is a legitimate feature
- the changes are necessary to make it fully functional for Matlab API
Contributor
Author
|
Also see commit 8261069 to understand why statements regarding the curvature check option flags are phrased the way they are. If |
Contributor
|
OpenCRG CCB 09.02.2026: @jorauh will review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local curvature check was incorrectly implemented and only worked in certain circumstances.
Changes to crg read and write were necessary to properly respect the global curvature check option.
The curvature check also did not follow the specification and the specification incorrectly stated the default global curvature options.
This implementation leaves the curvature check working as it was intended
but the intention is up for discussion.
Resolves: #8
Signed-off-by: Patrick Kuemmerle patrick.kuemmerle@3d-mapping.de