Add feedback on the PR (Azure#14820)

asager · Apr 23, 2021 · 948025f · 948025f
1 parent 64e42f3
commit 948025f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/tools/Az.Tools.Predictor/Az.Tools.Predictor/Az.Tools.Predictor.psd1 b/tools/Az.Tools.Predictor/Az.Tools.Predictor/Az.Tools.Predictor.psd1
@@ -43,7 +43,7 @@ PowerShellVersion = '7.2'
 # Modules that must be imported into the global environment prior to importing this module
 # RequiredModules = @(@{ModuleName="PSReadLine"; ModuleVersion="2.2.0-beta2"})
 
-# NestedModules = @("Microsoft.Azure.PowerShell.Tools.AzPredictor.dll")
+NestedModules = @("Microsoft.Azure.PowerShell.Tools.AzPredictor.dll")
 
 ScriptsToProcess = @("PromptSurvey.ps1")
 

diff --git a/tools/Az.Tools.Predictor/Az.Tools.Predictor/Commands/OpenAzSurvey.cs b/tools/Az.Tools.Predictor/Az.Tools.Predictor/Commands/OpenAzSurvey.cs
@@ -43,11 +43,10 @@ protected override void ProcessRecord()
             var profileSettings = Settings.GetProfileSettings();
             var surveyId = profileSettings?.SurveyId?.ToString(CultureInfo.InvariantCulture) ?? "000000";
 
-            var link = string.Format(OpenAzSurveyLink._SurveyLinkFormat, surveyId, CultureInfo.InvariantCulture);
+            var link = string.Format(OpenAzSurvey._SurveyLinkFormat, surveyId, CultureInfo.InvariantCulture);
 
-            Console.WriteLine($"Opening survey {link}");
+            Console.WriteLine($"Opening the default browser to {link}");
 
-            // TODO [mahuang] Ouput the link for user to copy/paste in case it's not open in the default browser.
             var processStartInfo = new ProcessStartInfo();
             processStartInfo.FileName = link;
             processStartInfo.UseShellExecute = true;

diff --git a/tools/Az.Tools.Predictor/Az.Tools.Predictor/InterceptSurvey.ps1 b/tools/Az.Tools.Predictor/Az.Tools.Predictor/InterceptSurvey.ps1
@@ -218,11 +218,10 @@ if ($shouldIntercept) {
         }
     }
 
-    Write-Host "---------------------------------------------------"; 
-    Write-Host "Survey:" -ForegroundColor $Host.PrivateData.VerboseBackgroundColor -BackgroundColor $host.PrivateData.VerboseForegroundColor -NoNewline; 
-    Write-Host " How was your experience using Az predictor?"; 
-    Write-Host ""; 
-    Write-Host "Run " -NoNewline; Write-Host "Open-AzSurvey" -ForegroundColor $Host.PrivateData.VerboseBackgroundColor -BackgroundColor $host.PrivateData.VerboseForegroundColor -NoNewline; Write-Host " to give us your feedback."; 
     Write-Host "---------------------------------------------------";
-
+    Write-Host "Survey:" -ForegroundColor $Host.PrivateData.VerboseBackgroundColor -BackgroundColor $host.PrivateData.VerboseForegroundColor -NoNewline;
+    Write-Host " How was your experience using the Az Predictor module?";
+    Write-Host "";
+    Write-Host "Run " -NoNewline; Write-Host "Open-AzSurvey" -ForegroundColor $Host.PrivateData.VerboseBackgroundColor -BackgroundColor $host.PrivateData.VerboseForegroundColor -NoNewline; Write-Host " to give us your feedback.";
+    Write-Host "---------------------------------------------------";
 }
diff --git a/tools/Az.Tools.Predictor/Az.Tools.Predictor/Utilities/JsonUtilities.cs b/tools/Az.Tools.Predictor/Az.Tools.Predictor/Utilities/JsonUtilities.cs
@@ -30,7 +30,7 @@ internal static class JsonUtilities
         /// 2. Use string instead of number for enums.
         /// 3. Use the string values (camel case) for enum.
         /// 4. Use the string values for the type <see cref="System.Version"/> in the properties and <see cref="System.Collections.Generic.IDictionary&lt;TKey, TValue>"/> keys.
-        /// 3. Skip the property if the value is null.
+        /// 5. Skip the property if the value is null.
         /// </summary>
         public static readonly JsonSerializerOptions DefaultSerializerOptions = new JsonSerializerOptions()
         {