fix: confusing nil in direct interface with typed nil

fix goccy#376
asaf-shitrit · Jul 2, 2022 · c8d6da8 · c8d6da8
1 parent 27bd0f2
commit c8d6da8
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 5 deletions.
diff --git a/encode_test.go b/encode_test.go
@@ -2406,3 +2406,21 @@ func TestIssue339(t *testing.T) {
 		t.Errorf("unexpected result: %v != %v", got, expected)
 	}
 }
+
+func TestIssue376(t *testing.T) {
+	type Container struct {
+		V interface{} `json:"value"`
+	}
+	type MapOnly struct {
+		Map map[string]int64 `json:"map"`
+	}
+	b, err := json.Marshal(Container{MapOnly{}})
+	if err != nil {
+		t.Fatal(err)
+	}
+	got := string(b)
+	expected := `{"value":{"map":null}}`
+	if got != expected {
+		t.Errorf("unexpected result: %v != %v", got, expected)
+	}
+}
diff --git a/internal/cmd/generator/vm.go.tmpl b/internal/cmd/generator/vm.go.tmpl
@@ -3,6 +3,7 @@ package vm
 
 import (
 	"math"
+	"reflect"
 	"sort"
 	"unsafe"
 
@@ -193,7 +194,8 @@ func Run(ctx *encoder.RuntimeContext, b []byte, codeSet *encoder.OpcodeSet) ([]b
 				ifacePtr = iface.ptr
 				typ = iface.typ
 			}
-			if ifacePtr == nil {
+			isDirectedNil := typ != nil && typ.Kind() == reflect.Struct && !runtime.IfaceIndir(typ)
+			if ifacePtr == nil && !isDirectedNil {
 				b = appendNullComma(ctx, b)
 				code = code.Next
 				break

diff --git a/internal/encoder/vm/vm.go b/internal/encoder/vm/vm.go
diff --git a/internal/encoder/vm_color/vm.go b/internal/encoder/vm_color/vm.go
diff --git a/internal/encoder/vm_color_indent/vm.go b/internal/encoder/vm_color_indent/vm.go
diff --git a/internal/encoder/vm_indent/vm.go b/internal/encoder/vm_indent/vm.go