Skip to content

Conversation

@yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Jul 29, 2021

@willemneal It's a fix PR same with AssemblyScript/assemblyscript#1998.
Many transforms written rely on visitor-as. If the modified file uses this syntax, then some exported APIs are not exported normally

@yjhmelody
Copy link
Contributor Author

@willemneal Can you merge it if no other problem?

@willemneal
Copy link
Collaborator

I still don't like that we have a different version of astBulider than the AS repo, but thanks for keeping them in agreement!

@willemneal willemneal merged commit eb58d3b into as-pect:master Aug 2, 2021
@yjhmelody yjhmelody deleted the fix-ast-builder branch August 3, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants