Fix issues with immer::box when used in collections #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix involves preferring () to {} when calling placement-new generally,
as the latter often leads to the initialization_list based constructor
to be preferred, which causes the issue.
This was introduced in:
6d22844
This reintroduces the check that was removed in: 6d22844 It does so in a way that is compatible with incomplete types.
They are pseudo-deterministically flaky? Depends on when GC gets triggered... Seems mostly deterministic for a single buidl, but the points change whenever you really change the code in any way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in the individual commits.
Ping @aimoonchen @alex-sparus