feat(revset): Add exactly function
#508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in discord, this adds an
exactlyrevset function. This returns the given revset only if it contains the expected number of commits. Otherwise it errors out. This was very straightforward to implement and includes tests.Notes
countfunction that would behave like the text/date matchers, for example:count(<revset>, exactly:1)count(<revset>, greater_than:2)count(<revset>, less_than_or_equal_to:3), etc.sole()function, but I removed that in favor of making it an alias forexactly($1, 1)using the revset aliases PR.if ! git query exactly(parents($INPUT), 1) ; then exit ; fito prevent myself from accidentally operating on a merge commit.ExpectedSingletonSetappears to be unused. Should it be removed or would you like to keep it around?