Skip to content

feat(submit): add --dry-run flag #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

feat(submit): add --dry-run flag #1129

merged 1 commit into from
Nov 10, 2023

Conversation

@claytonrcarter
Copy link
Collaborator

@claytonrcarter claytonrcarter commented Nov 8, 2023

submit is inherently side effecting in non-obvious-to-undo ways. This is a rudimentary attempt to add a --dry-run flag to see what submit would be trying to do.

claytonrcarter
claytonrcarter commented Nov 9, 2023
View reviewed changes
claytonrcarter
claytonrcarter commented Nov 9, 2023
View reviewed changes
@claytonrcarter claytonrcarter marked this pull request as ready for review November 9, 2023 00:56
@claytonrcarter claytonrcarter mentioned this pull request Nov 9, 2023
Merged
arxanas
arxanas approved these changes Nov 10, 2023
View reviewed changes
Copy link
Owner

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@claytonrcarter claytonrcarter enabled auto-merge (rebase) November 10, 2023 10:54
@claytonrcarter claytonrcarter merged commit 9adbb9b into arxanas:master Nov 10, 2023
@claytonrcarter claytonrcarter deleted the crc/submit-dry-run branch November 10, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arxanas arxanas arxanas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@claytonrcarter @arxanas