Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for compare method standard error sorting consistency (#2350) #2407

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

uzairgheewala
Copy link

@uzairgheewala uzairgheewala commented Jan 12, 2025

Description

This PR adds a test to verify that standard errors maintain their proper association with models in the compare method's output, regardless of input order.

The problem of standard errors not properly maintaining their association with models when the input order changed as mentioned in #2350 was resolved in issue #2351 but #2350 was left open for a test to be added to check just that.

Checklist

  • Follows official PR format
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2407.org.readthedocs.build/en/2407/

@uzairgheewala
Copy link
Author

The ReadTheDocs build appears to be failing due to a documentation system error related to type hints (FilePath not defined). This seems unrelated to the test changes.

Any assistance that could be provided would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant