Skip to content

Conversation

@sethaxen
Copy link
Member

Fixes #20.

Benchmarks:

julia> using PSIS

julia> x1 = randn(1_000);

julia> x2 = randn(100, 1_000, 4);

Before this PR:

julia> @btime $psis($x);
  89.436 μs (7 allocations: 16.75 KiB)

julia> @btime $psis($x2);
  16.521 ms (1144 allocations: 6.24 MiB)

After this PR:

julia> @btime $psis($x);
  71.606 μs (10 allocations: 16.86 KiB)

julia> @btime $psis($x2);
  7.827 ms (1444 allocations: 6.25 MiB)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.06%. Comparing base (ae98bab) to head (ba6bf0e).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   97.06%   97.06%           
=======================================
  Files           8        8           
  Lines         307      307           
=======================================
  Hits          298      298           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sethaxen sethaxen merged commit 1af98ee into main Dec 30, 2021
@sethaxen sethaxen changed the title Sort only upper tail waits Sort only upper tail weights Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only sort the upper tail weights

2 participants