Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network simplification script #79

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Fix network simplification script #79

merged 1 commit into from
Apr 28, 2021

Conversation

mfitz
Copy link
Contributor

@mfitz mfitz commented Apr 28, 2021

The network simplification tool had not been updated for the recent changes to GeNet's core network API. At the time I created this PR, I didn't think about the other scripts, but some of them will no doubt be suffering from the same problem - let's fix all of those in a different PR.

Running a Matesto pipeline including a network simplification step before this change

Screen Shot 2021-04-28 at 03 29 51

Screen Shot 2021-04-28 at 03 30 15

Running a Matesto pipeline including a network simplification step after this change

Screen Shot 2021-04-28 at 03 24 22

Screen Shot 2021-04-28 at 03 25 48

@mfitz mfitz requested a review from KasiaKoz April 28, 2021 02:44
@mfitz mfitz merged commit ed78846 into master Apr 28, 2021
@KasiaKoz KasiaKoz mentioned this pull request Apr 29, 2021
@mfitz mfitz deleted the mf_fix_simplify_network branch November 18, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants