PT headways #102
Merged
PT headways #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # genet/schedule_elements.py # tests/test_core_components_route.py # tests/test_core_components_service.py # tests/test_core_schedule.py
gac55
reviewed
Nov 30, 2021
There was a problem hiding this comment.
Clarification question.
Does this implement a given headway across the entire day uniformly? I can imagine this having unintended consequences, for example, creating services early in the morning or late at night that we may not want. Does this make that configurable?
| @@ -598,6 +610,16 @@ def routes(self): | |||
| yield self | |||
|
|
|||
| def route_trips_with_stops_to_dataframe(self, gtfs_day='19700101'): | |||
| """ | |||
| This method exists for backwards compatibility only | |||
The headway specification is a dictionary in this format: {('01:00:00', '02:00:00'): 20,
('02:00:00', '03:00:00'): 30}the spec requires you to specify the temporal bound, you can have various headways across the day. And then of course for a uniform headway in a day you can just specify {('00:00:00', '23:59:59'): 20}I updated my PR description with this, pretty big omission on my part, soz |
gac55
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MATSim requires explicit trips with vehicles for all PT Services. Sometimes we only know the headway in a time bracket for a service, this PR adds a few new convenience methods to:
pandas.DataFrame[ref]pandas.DataFrame[ref]This will help with generating PT scenarios.
The headway specification is a dictionary in this format:
(time_from, time_to): headway in minutes, e.g.{('01:00:00', '02:00:00'): 20, ('02:00:00', '03:00:00'): 30}Will come out with these trips:
This can be more complicated with only some trips being injected among an existing set of trips to try and match a headway, but we propose this simple addition to current functionality for the time being.