Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dialog): default button support #56

Merged
merged 4 commits into from
Feb 28, 2019
Merged

feat(dialog): default button support #56

merged 4 commits into from
Feb 28, 2019

Conversation

arturmiz
Copy link
Owner

Closes #48

@arturmiz arturmiz added enhancement New feature or request component: dialog Dialog component issues labels Feb 20, 2019
@arturmiz arturmiz self-assigned this Feb 20, 2019
@codecov
Copy link

codecov bot commented Feb 26, 2019 •
edited
Loading

Codecov Report

Merging #56 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage    98.6%   98.68%   +0.08%     
==========================================
  Files          30       30              
  Lines         143      152       +9     
  Branches       26       29       +3     
==========================================
+ Hits          141      150       +9     
  Misses          2        2
Impacted Files Coverage Δ
src/components/dialog/Dialog.vue 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61957be...1f94c4c. Read the comment docs.

@arturmiz arturmiz marked this pull request as ready for review February 28, 2019 08:22
@arturmiz arturmiz merged commit 0036354 into master Feb 28, 2019
@arturmiz arturmiz deleted the feat/dialog/default-button-support branch February 28, 2019 21:40
@arturmiz arturmiz added this to the v0.6.0 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arturmiz arturmiz

Labels
component: dialog Dialog component issues enhancement New feature or request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Default button support in Dialog
1 participant
@arturmiz