0.4.19 breaks multi-service account helm charts

[imilchev]

Release 0.4.19 is breaking generating helm charts from manifests with >1 service account included in them. The code in 0.4.19 assumes there is only 1 service account to be created by the helm chart which is not always the case. I have a helm chart with 3 service accounts and after running helmify I end up with this serviceaccount.yaml:

{{ if .Values.serviceAccount.create }}
apiVersion: v1
kind: ServiceAccount
metadata:
  name: {{ include "mondoo-operator.serviceAccountName" . }}
  labels:
  {{- include "mondoo-operator.labels" . | nindent 4 }}
  {{- with .Values.serviceAccount.annotations }}
  annotations:
    {{- toYaml . | nindent 4 }}
  {{- end }}
automountServiceAccountToken: {{ .Values.serviceAccount.automount }}
{{- end }}
---
{{ if .Values.serviceAccount.create }}
apiVersion: v1
kind: ServiceAccount
metadata:
  name: {{ include "mondoo-operator.serviceAccountName" . }}
  labels:
  {{- include "mondoo-operator.labels" . | nindent 4 }}
  {{- with .Values.serviceAccount.annotations }}
  annotations:
    {{- toYaml . | nindent 4 }}
  {{- end }}
automountServiceAccountToken: {{ .Values.serviceAccount.automount }}
{{- end }}
---
{{ if .Values.serviceAccount.create }}
apiVersion: v1
kind: ServiceAccount
metadata:
  name: {{ include "mondoo-operator.serviceAccountName" . }}
  labels:
  {{- include "mondoo-operator.labels" . | nindent 4 }}
  {{- with .Values.serviceAccount.annotations }}
  annotations:
    {{- toYaml . | nindent 4 }}
  {{- end }}
automountServiceAccountToken: {{ .Values.serviceAccount.automount }}
{{- end }}

[Starefossen]

I had to revert to v0.4.18, Claude tried to come up with a fix for my setup but without any results:

Now I understand the helmify change. The key change in pkg/processor/rbac/serviceaccount.go is:

Before (0.4.18): Used processor.ProcessObjMeta() which templated the name from input
After (0.4.19): Hardcodes {{ include "chartname.serviceAccountName" . }} and creates new values structure

The new serviceAccountName helper defaults to just fullname when name: "", losing the -controller-manager suffix.

The fix: The kustomize source name determines the default. Looking at your [service_account.yaml](vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html), the name is controller-manager.

The problem is helmify 0.4.19 ignores the actual SA name from kustomize and always uses the helper with fullname as default. This is a helmify bug/behavior change - no kustomize change can fix this.