feat: expose Gravity's viewingRoomsConnection to replace deprecated v…

…iewingRooms query (#6030)
artsy · Sep 20, 2024 · a063615 · a063615
1 parent 55db42f
commit a063615
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 28 deletions.
diff --git a/_schemaV2.graphql b/_schemaV2.graphql
@@ -15963,27 +15963,6 @@ type Query {
     last: Int
     userId: ID!
   ): UserAddressConnection
-
-  # List viewing rooms
-  _unused_gravity_viewingRoomsConnection(
-    # Returns the elements in the list that come after the specified cursor.
-    after: String
-
-    # Returns the elements in the list that come before the specified cursor.
-    before: String
-    featured: Boolean
-
-    # Returns the first _n_ elements from the list.
-    first: Int
-    ids: [ID!]
-
-    # Returns the last _n_ elements from the list.
-    last: Int
-    partnerID: ID
-
-    # Returns only viewing rooms with these statuses
-    statuses: [ViewingRoomStatusEnum!] = [live]
-  ): ViewingRoomsConnection
   admin: Admin
 
   # Find an agreement by ID
@@ -17257,6 +17236,27 @@ type Query {
     # Returns only viewing rooms with these statuses
     statuses: [ViewingRoomStatusEnum!] = [live]
   ): ViewingRoomConnection @deprecated(reason: "Use viewingRoomsConnection")
+
+  # List viewing rooms
+  viewingRoomsConnection(
+    # Returns the elements in the list that come after the specified cursor.
+    after: String
+
+    # Returns the elements in the list that come before the specified cursor.
+    before: String
+    featured: Boolean
+
+    # Returns the first _n_ elements from the list.
+    first: Int
+    ids: [ID!]
+
+    # Returns the last _n_ elements from the list.
+    last: Int
+    partnerID: ID
+
+    # Returns only viewing rooms with these statuses
+    statuses: [ViewingRoomStatusEnum!] = [live]
+  ): ViewingRoomsConnection
 }
 
 type Quiz {

diff --git a/src/lib/stitching/gravity/__tests__/stitching.test.ts b/src/lib/stitching/gravity/__tests__/stitching.test.ts
@@ -466,7 +466,7 @@ describe("gravity/stitching", () => {
       expect(info.mergeInfo.delegateToSchema).toHaveBeenCalledWith({
         args: { partnerID: "partner-id", first: 2 },
         operation: "query",
-        fieldName: "_unused_gravity_viewingRoomsConnection",
+        fieldName: "viewingRoomsConnection",
         schema: expect.anything(),
         context: expect.anything(),
         info: expect.anything(),
@@ -497,7 +497,7 @@ describe("gravity/stitching", () => {
       expect(info.mergeInfo.delegateToSchema).toHaveBeenCalledWith({
         args: { ids: ["view-lots-of-cats-id"] },
         operation: "query",
-        fieldName: "_unused_gravity_viewingRoomsConnection",
+        fieldName: "viewingRoomsConnection",
         schema: expect.anything(),
         context: expect.anything(),
         info: expect.anything(),

diff --git a/src/lib/stitching/gravity/schema.ts b/src/lib/stitching/gravity/schema.ts
@@ -8,7 +8,12 @@ import {
 } from "graphql-tools"
 import { readFileSync } from "fs"
 
-const rootFieldsAllowList = ["agreement", "viewingRoom", "viewingRooms"]
+const rootFieldsAllowList = [
+  "agreement",
+  "viewingRoom",
+  "viewingRooms",
+  "viewingRoomsConnection",
+]
 
 export const executableGravitySchema = () => {
   const gravityTypeDefs = readFileSync("src/data/gravity.graphql", "utf8")

diff --git a/src/lib/stitching/gravity/v2/stitching.ts b/src/lib/stitching/gravity/v2/stitching.ts
@@ -179,7 +179,7 @@ export const gravityStitchingEnvironment = (
             return info.mergeInfo.delegateToSchema({
               schema: gravitySchema,
               operation: "query",
-              fieldName: "_unused_gravity_viewingRoomsConnection",
+              fieldName: "viewingRoomsConnection",
               args: {
                 partnerID,
                 ...args,
@@ -203,7 +203,7 @@ export const gravityStitchingEnvironment = (
             return info.mergeInfo.delegateToSchema({
               schema: gravitySchema,
               operation: "query",
-              fieldName: "_unused_gravity_viewingRoomsConnection",
+              fieldName: "viewingRoomsConnection",
               args: {
                 ids,
               },
@@ -428,7 +428,7 @@ export const gravityStitchingEnvironment = (
             return info.mergeInfo.delegateToSchema({
               schema: gravitySchema,
               operation: "query",
-              fieldName: "_unused_gravity_viewingRoomsConnection",
+              fieldName: "viewingRoomsConnection",
               args: {
                 ...args,
                 ids,
@@ -449,7 +449,7 @@ export const gravityStitchingEnvironment = (
             return info.mergeInfo.delegateToSchema({
               schema: gravitySchema,
               operation: "query",
-              fieldName: "_unused_gravity_viewingRoomsConnection",
+              fieldName: "viewingRoomsConnection",
               args,
               context,
               info,