Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Media] Suppress hydration warning when not matching breakpoint. #83

Merged
merged 2 commits into from
May 22, 2019

Conversation

alloy
Copy link
Collaborator

@alloy alloy commented May 22, 2019

Fixes #78

<div
className={`rrm-container ${className}`}
suppressHydrationWarning={!renderChildren}
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! so it was a new version of React. I tried this exact thing.

@damassi
Copy link
Member

damassi commented May 22, 2019

👍

@damassi damassi merged commit 5170f93 into master May 22, 2019
@alloy alloy deleted the suppress-expected-hydration-warning branch May 22, 2019 17:49
@artsyit
Copy link
Contributor

artsyit commented May 22, 2019

🚀 PR was released in v2.0.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress hydration warning for Media components that do not match
3 participants