Update production keepalive/header timeouts to avoid hung connections to ELB #5522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5522 +/- ##
======================================
Coverage 79.5% 79.5%
======================================
Files 1245 1245
Lines 33903 33903
Branches 2048 2048
======================================
Hits 26955 26955
Misses 5938 5938
Partials 1010 1010 |
|
Historical context: #3568 (comment) |
|
Given that production isn't currently having issues, let's hold on this. |
|
@zephraph can this be closed? |
|
Oh, definitely yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to nodejs/node#27363
Background:
Somewhere after Node 10.13 a security fix for the slow mo attack was added to node. This caused us to see an elevated rate of 502s due to some timeout connections between the node processes and the ELB. (I won't pretend to understand all the specifics). @mzikherman updated node for force and added the these settings for staging in #5022, but that we never updated production... which seems important?
I'm also going through this song and dance for metaphysics via artsy/metaphysics#2358