feat(EMI-2159): Auction registration address autocomplete #14846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdstock
changed the title
damassi
reviewed
Nov 14, 2024
| setHasAutocompletedAddress(false) | ||
| } | ||
| handleChange(...args) | ||
| } |
There was a problem hiding this comment.
Couple things with this:
- if we have a tracking hook that co-locates all tracking, then we shouldn't be defining local functions that also handle tracking; we should figure out how to make it ideal, such as adding a second callback argument to
editedAutocompletedAddressand then invoking that - Or (and better) renaming the local function:
handleAutocompleteChangeand then invoking the tracking function from that - Also, no need to pass in
handleChangeas an argument; its already in scope up above
There was a problem hiding this comment.
yeah, mostly agree here. I'll see if i can improve it a little more.
damassi
reviewed
Nov 14, 2024
| @@ -80,7 +127,7 @@ export const AddressForm = () => { | |||
| /> | |||
| </Column> | |||
|
|
|||
| <Column span={6}> | |||
| <Column span={12}> | |||
erikdstock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: FEAT
This PR solves EMI-2159
Description
This PR adds autocomplete for US addresses on auction registration and makes minor changes to the registration form layout to follow our latest specs for address forms.