Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client-side email address validation makes unhelpful suggestions. #771

Open
alloy opened this issue Jan 25, 2017 · 6 comments
Open

Client-side email address validation makes unhelpful suggestions. #771

alloy opened this issue Jan 25, 2017 · 6 comments
Labels
Collector Experience Enhancement

Comments

@alloy
Copy link
Contributor

alloy commented Jan 25, 2017

From #766.

In this example, the suggestion doesn’t include a TLD and using it would still not make the field validate, so it seems like an unhelpful suggestion. We use this across the site, so improving it touches many places.
@alloy alloy changed the title Our email client-side validation library yields unhelpful suggestions. Client-side email address validation makes unhelpful suggestions. Jan 25, 2017
@alloy alloy mentioned this issue Jan 25, 2017
Merged
@alloy
Copy link
Contributor Author

alloy commented Jan 25, 2017

The library we use is https://github.com/mailcheck/mailcheck

@kanaabe
Copy link
Contributor

kanaabe commented Jan 25, 2017

#754 (comment)

@alloy
Copy link
Contributor Author

alloy commented Jan 25, 2017

Copying @kanaabe's comment here mailcheck/mailcheck#139

This definitely looks like the issue. A PR seems to have been up for 3 months.

Can someone npm instal from that person's branch and see if it indeed fixes the issue?

@1aurabrown 1aurabrown self-assigned this Feb 10, 2017
@1aurabrown 1aurabrown mentioned this issue Feb 10, 2017
Closed
@alloy
Copy link
Contributor Author

alloy commented Feb 10, 2017

@1aurabrown We should probably install mailcheck from the git repo and, if it does indeed fix the issue for us, ask the mailcheck maintainers to do a release with that fix.

@1aurabrown
Copy link

I installed from the latest commit from mailcheck, which includes that PR, and nothing seems to have changed

screen shot 2017-02-13 at 4 22 27 pm

@alloy
Copy link
Contributor Author

alloy commented Feb 14, 2017

Should we switch or take ownership?

@1aurabrown 1aurabrown removed their assignment Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Collector Experience Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alloy @kanaabe @1aurabrown