[Dev] Provide advice on how to clone, and provide a checklist for signing

[orta]

This is WIP - need to null out whether the tick is checked in the "has this been changed" and thus needs to update.

---

Tested on Device?

• @orta
• @alloy
• @l2succes
• @mennenia
• @sarahscott

How to get set up with this PR?

 

To run on your computer:

git fetch origin pull/558/head:orta-558-checkout
git checkout orta-558-checkout
yarn install
cd example; pod install; cd ..
open -a Simulator
yarn start

Then run xcrun simctl launch booted net.artsy.Emission once a the simulator has finished booting

To run inside Eigen (prod or beta) or Emission (beta): Shake the phone to get the Admin menu.

If you see "Use Staging React Env" - click that and restart, then follow the next step.

Click on "Choose an RN build" - then pick the one that says: "X,Y,Z"

Note: this is a TODO for PRs, currently you can only do it on master commits.

[orta]

Doing many peeps so I can see if it handles that correct

[mennenia]

Huh, the formatting broke in this one? :o

edit: it seems to be adding spaces after the < tags

[orta]

Thanks - fixed, being redeployed atm

[orta]

OK, it'll now it won't reset the ticks on new danger runs. I think, we'll find out if mine + @mennenia's ticks disappear.

[orta]

Aww, it did. Hrm.

[orta]

❓ Anyone got an idea, this looks like I'd expect.

> const a = "- [x] asdasdasdda;\n - [ ] asdazzxxzxc".replace(/- \[*.\]/g, "---")
undefined
> const b = "- [x] asdasdasdda;\n - [x] asdazzxxzxc".replace(/- \[*.\]/g, "---")
undefined
> a === b
true

Wonder if there's an extra newline somewhere.

[orta]

It looks like it was whitespacing

[orta]

👍

[l2succes]

@orta not sure why but yarn ios doesn't work for me so I have to run Xcode manually. Not a blocker but making a note in case it happens to other people.

Edit: I saw this issue in the react-native repo, tried a few things, nothing worked. I'll report back when I find a fix facebook/react-native#11293

[orta]

To my knowledge it doesn't do much - we might be able to replicate it from our side pretty easily, we'd need a command that opens the right sim, then with the right app

[orta]

In theory it can be:

open -a Simulator
echo "Once the simulator has loaded: xcrun simctl launch booted net.artsy.Emission"

[sarahscott]

Very small thing but cd example; pod install cd .. should be cd example; pod install; cd ..

[sarahscott]

Otherwise the setup instructions work for me!

[orta]

Good catch - I have enough open PRs, so self-merging this 👍