-
Notifications
You must be signed in to change notification settings - Fork 592
refactor(DIA-1281): Code cleanup on InfiniteDiscovery #12007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
araujobarret
merged 6 commits into
main
from
araujobarret/refactor/infinite-discover-code-reorg
May 2, 2025
Merged
refactor(DIA-1281): Code cleanup on InfiniteDiscovery #12007
araujobarret
merged 6 commits into
main
from
araujobarret/refactor/infinite-discover-code-reorg
May 2, 2025
+432
−414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damassi
reviewed
Apr 29, 2025
@@ -54,7 +42,7 @@ export const InfiniteDiscoveryArtworkCard: React.FC<InfiniteDiscoveryArtworkCard | |||
const setHasSavedArtwors = GlobalStore.actions.infiniteDiscovery.setHasSavedArtworks | |||
const gestureState = useRef({ lastTapTimestamp: 0, numTaps: 0 }) | |||
|
|||
const { trackEvent } = useTracking() | |||
const track = useInfiniteDiscoveryTracking() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
damassi
reviewed
Apr 29, 2025
src/app/Scenes/InfiniteDiscovery/Components/InfiniteDiscoveryArtworkCardPopover.tsx
Show resolved
Hide resolved
damassi
reviewed
Apr 29, 2025
src/app/Scenes/InfiniteDiscovery/Components/InfiniteDiscoveryHeader.tsx
Outdated
Show resolved
Hide resolved
damassi
reviewed
Apr 29, 2025
src/app/Scenes/InfiniteDiscovery/Components/InfiniteDiscoverySpinner.tsx
Outdated
Show resolved
Hide resolved
damassi
reviewed
Apr 29, 2025
}) | ||
}, | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks much 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves DIA-1281
Description
No Changes expected, just code org:
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.