fix: adjust tapped navigation tab event #11913
Open
+16
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
previously approved these changes
Apr 15, 2025
Comment on lines
38
to
48
| const trackTappedInfoBubble = () => { | ||
| let contextModule: ContextModule | ||
| switch (activeTab) { | ||
| case "saves": | ||
| contextScreen = ContextModule.favoritesSaves | ||
| contextModule = ContextModule.favoritesSaves | ||
| break | ||
| case "follows": | ||
| contextScreen = ContextModule.favoritesFollows | ||
| contextModule = ContextModule.favoritesFollows | ||
| break | ||
| case "alerts": | ||
| contextScreen = ContextModule.favoritesAlerts | ||
| contextModule = ContextModule.favoritesAlerts |
There was a problem hiding this comment.
To avoid maintaining this and forgetting to add new context modules if we add new tabs, maybe we can add the context module to Pills inside Favorites.tsx.
There was a problem hiding this comment.
Good point, addressing it now
dariakoko
added
the
Squash On Green
MounirDhahri
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
As requested by data, adjust the tracking of the pill tap event
Slack thread: https://artsy.slack.com/archives/C05EQL4R5N0/p1744376580199449?thread_ts=1742927066.401229&cid=C05EQL4R5N0
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.