-
Notifications
You must be signed in to change notification settings - Fork 592
chore: update reanimated to 3.17.2 #11852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (2)
- package.json: Language not supported
- patches/react-native-reanimated+3.17.2.patch: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, do you mind though doing:
- the same on palette-mobile so we can be on the same version in both?
- sent out a practice-mobile communication that this thing happened and also paste this script in case people need to clear the caches after fetching from main:
rm -rf node_modules && rm -rf .cache && rm -rf "$TMPDIR/metro*" && rm -rf "$TMPDIR/haste-map-*"
yarn install:all
yarn start --reset-cache
@@ -27,20 +27,11 @@ index a427011..9244d1b 100644 | |||
} | |||
export type FlatListPropsWithLayout<T> = ReanimatedFlatListPropsWithLayout<T>; | |||
interface AnimatedFlatListComplement<T> extends FlatList<T> { | |||
diff --git a/node_modules/react-native-reanimated/lib/typescript/component/FlatList.d.ts.map b/node_modules/react-native-reanimated/lib/typescript/component/FlatList.d.ts.map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this intentionally removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this was the output of patch-package
Description
Screen.Recording.2025-04-07.at.12.36.15.mov
Screen.Recording.2025-04-07.at.15.03.21.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.