Skip to content

chore: update reanimated to 3.17.2 #11852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Apr 7, 2025

Description

Platform iOS Android
Video
Screen.Recording.2025-04-07.at.12.36.15.mov
Screen.Recording.2025-04-07.at.15.03.21.mov

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • update reanimated to 3.17.2

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri requested a review from Copilot April 7, 2025 13:01
@MounirDhahri MounirDhahri self-assigned this Apr 7, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • package.json: Language not supported
  • patches/react-native-reanimated+3.17.2.patch: Language not supported

@MounirDhahri MounirDhahri requested a review from gkartalis April 7, 2025 13:02
@MounirDhahri MounirDhahri marked this pull request as ready for review April 7, 2025 13:02
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Apr 7, 2025

This PR contains the following changes:

  • Dev changes (update reanimated to 3.17.2 - MounirDhahri)

Generated by 🚫 dangerJS against 6dd1d39

gkartalis
gkartalis previously approved these changes Apr 7, 2025
Copy link
Member

@gkartalis gkartalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, do you mind though doing:

  • the same on palette-mobile so we can be on the same version in both?
  • sent out a practice-mobile communication that this thing happened and also paste this script in case people need to clear the caches after fetching from main:
rm -rf node_modules && rm -rf .cache && rm -rf "$TMPDIR/metro*" && rm -rf "$TMPDIR/haste-map-*"

yarn install:all

yarn start --reset-cache

@@ -27,20 +27,11 @@ index a427011..9244d1b 100644
}
export type FlatListPropsWithLayout<T> = ReanimatedFlatListPropsWithLayout<T>;
interface AnimatedFlatListComplement<T> extends FlatList<T> {
diff --git a/node_modules/react-native-reanimated/lib/typescript/component/FlatList.d.ts.map b/node_modules/react-native-reanimated/lib/typescript/component/FlatList.d.ts.map
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this intentionally removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this was the output of patch-package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants