Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): migrate to more secure library for secret management #11446

Merged
merged 25 commits into from
Jan 31, 2025

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Jan 27, 2025

This PR resolves PHIRE-1488, PHIRE-1489, PHIRE-1490, PHIRE-1491, PHIRE-474

Description

Deprecates and removes react-native-config library in favor of react-native-keys

You can read more on how the react-native-keys library works and protects our secret keys here

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • migrate secrets from react-native-config to react-native-keys

Need help with something? Have a look at our docs, or get in touch with us.

Not Found
@brainbicycle brainbicycle self-assigned this Jan 27, 2025
@brainbicycle brainbicycle marked this pull request as draft January 27, 2025 22:14
@gkartalis gkartalis force-pushed the gkartalis/PHIRE-1344 branch 2 times, most recently from fba1742 to 0c15a4c Compare January 29, 2025 12:00
@gkartalis
Copy link
Member

android-8.63.0-1674646021

ios-8.63.0-2025.01.29.12

gkartalis and others added 24 commits January 30, 2025 10:37
Co-authored-by: brainbicycle <brian.beckerle@artsymail.com>
Co-authored-by: George <g.kartalis7@gmail.com>
Co-authored-by: George <g.kartalis7@gmail.com>
Co-authored-by: George <g.kartalis7@gmail.com>
Co-authored-by: George <g.kartalis7@gmail.com>
Co-authored-by: brainbicycle <brian.beckerle@artsymail.com>
@gkartalis
Copy link
Member

Fresh Betas:

android-8.63.0-1674646025
8.63.0 - 2025.1.30.10

@gkartalis gkartalis marked this pull request as ready for review January 30, 2025 13:50
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Dev changes (migrate secrets from react-native-config to react-native-keys - brainbicycle)

Generated by 🚫 dangerJS against 420dc1d

@brainbicycle brainbicycle changed the title [DO NOT MERGE] - chore(deps): migrate to react native keys chore(deps): migrate to react native keys Jan 30, 2025
@gkartalis gkartalis changed the title chore(deps): migrate to react native keys feat(deps): migrate to more secure library for secret management Jan 31, 2025
Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! thanks, this is so useful

@brainbicycle brainbicycle merged commit b8177b0 into main Jan 31, 2025
12 checks passed
@brainbicycle brainbicycle deleted the gkartalis/PHIRE-1344 branch January 31, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants