-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Captions do not hide after update via API #218
Comments
What about this. If I needed to add a div into the ‘thumbs div’ so that I could dynamically add text in there. finally I would love to know how access the style tag that is being added via javascript to the Please help me with this.. You don’t have to tell me line for line how to do this, but can you please tell me where in your javascript does what. I can not make any sense of the code and there are no comments in there telling me what I need to go. I would even be willing to pay for your help, if the amount is not off the charts. but I think my questions are simple enough for someone as good as you sir. Please respond. Thank you |
@roelvanduijnhoven and @yhwhdesign please check the code I attached in #208 |
Fixed: http://jsfiddle.net/6uw5b/1/ |
I just now saw the message so I will check it out.. Thank you very much!!! Jasen Burkett / Web Developer The information contained in this electronic message is intended for the exclusive use of the individual or entity named above and may contain privileged or confidential copyrighted information. If the reader of this message is not the intended recipient or the employee or agent responsible to deliver it to the intended recipient, you are hereby notified that dissemination, distribution or copying of this information is prohibited. If you have received this communication in error, please notify the sender immediately. On Mar 29, 2014, at 9:08 AM, Ferhat notifications@github.com wrote:
|
I re read my questions and they were not very good. Here is a more accurate list of what I am looking to do, and again I am not wanting you to do all the work, you have done such an amazing job on the slider, however the tweaks I need to do, I would rather do myself, I just do not know how to find the components in the javascript to do so. I need to find where in the javascript that the thumbnails are being made so that I can add a div container underneath them. I need to know where in the javascript I can add navigation arrows that match the ones on the full image, however i need to place them on the thumbs. There is some ‘style’ tags that are being added via the javascript to make the next and previous images be hidden out of view, however I need to know how to edit the margin and the left style that is being added to those images so that I can pull them in next to the active image. Finally, in the javascript and or the css, there is the code that makes the arrows fade away when you move your mouse on and off the slider… how could I find this code so that I can add it to other components in this slider. I am willing to pay for the information, I do not have a lot of money but I know you have to be busy and may not have time to just answer all of my questions. The above questions are all that I have, and would be forever grateful if you would please let me know the answers. thank you for your time its much appreciated. Jasen Burkett / Web Developer The information contained in this electronic message is intended for the exclusive use of the individual or entity named above and may contain privileged or confidential copyrighted information. If the reader of this message is not the intended recipient or the employee or agent responsible to deliver it to the intended recipient, you are hereby notified that dissemination, distribution or copying of this information is prohibited. If you have received this communication in error, please notify the sender immediately. On Mar 31, 2014, at 8:50 AM, Jasen Burkett jburkett@arkansasonline.com wrote:
|
|
I greatly appreciate your time and help on this. I will go through the solutions you provided and make the changes. If I have any further questions I will let you know but I think you have taken care of any / all issues. Thank you greatly!!!! Jasen Burkett / Web Developer The information contained in this electronic message is intended for the exclusive use of the individual or entity named above and may contain privileged or confidential copyrighted information. If the reader of this message is not the intended recipient or the employee or agent responsible to deliver it to the intended recipient, you are hereby notified that dissemination, distribution or copying of this information is prohibited. If you have received this communication in error, please notify the sender immediately. On Apr 1, 2014, at 12:08 PM, Ferhat notifications@github.com wrote:
|
Quick question. I noticed that in your js file your referencing on the first link… that is not the same js file I have. Is the one you referenced a newer file? on line 294 i have the following: } the one you showed me looks totally different! Please advise Jasen Burkett / Web Developer The information contained in this electronic message is intended for the exclusive use of the individual or entity named above and may contain privileged or confidential copyrighted information. If the reader of this message is not the intended recipient or the employee or agent responsible to deliver it to the intended recipient, you are hereby notified that dissemination, distribution or copying of this information is prohibited. If you have received this communication in error, please notify the sender immediately. On Apr 1, 2014, at 12:08 PM, Ferhat notifications@github.com wrote:
|
Question. The master files do not work, some of the examples work but why is this file set different from the website version? and why does it not work, unlike the website version the only trouble is with the javascript file. What am I missing? Jasen Burkett / Web Developer The information contained in this electronic message is intended for the exclusive use of the individual or entity named above and may contain privileged or confidential copyrighted information. If the reader of this message is not the intended recipient or the employee or agent responsible to deliver it to the intended recipient, you are hereby notified that dissemination, distribution or copying of this information is prohibited. If you have received this communication in error, please notify the sender immediately. On Apr 1, 2014, at 12:08 PM, Ferhat notifications@github.com wrote:
|
The version I referenced is from the master branch and upstream is usually more recent than the code you may have localy. So, I'd suggest you do a |
I was able to find the similar code in the output files that was made. Compared to the code you showed me. However its just the lack of knowing how he uses javascript to build the div containers, etc. that is bogging me down. I hope to figure it out soon. Jasen Burkett / Web Developer The information contained in this electronic message is intended for the exclusive use of the individual or entity named above and may contain privileged or confidential copyrighted information. If the reader of this message is not the intended recipient or the employee or agent responsible to deliver it to the intended recipient, you are hereby notified that dissemination, distribution or copying of this information is prohibited. If you have received this communication in error, please notify the sender immediately. On Apr 2, 2014, at 9:49 AM, Jasen Burkett jburkett@arkansasonline.com wrote:
|
Can you do a quick fiddle on the following to help me again? If not I understand.
I thank you for your time, and if I need to pay you for the answers to the above questions let me know how much it would cost, I don’t have much but I can try to give you something. I still can not get anything to work, and Im not sure where to start… I have attached my files to this email so that you can see what I am working with. The javascript and the css files are copied and pasted below.
/*!
if (!JQUERY_VERSION var Modernizr = (function (window, document, undefined) { var version = '2.6.2',
if (!is(_hasOwnProperty, 'undefined') && !is(_hasOwnProperty.call, 'undefined')) { if (!Function.prototype.bind) {
} function setCss (str) { function setCssAll (str1, str2) { function is (obj, type) { function contains (str, substr) { function testProps (props, prefixed) { function testDOMProps (props, obj, elem) {
} function testPropsAll (prop, prefixed, elem) {
} tests['csstransforms3d'] = function () {
// Chrome fails that test, ignore for (var feature in tests) {
} Modernizr.addTest = function (feature, test) {
}; setCss(''); Modernizr._version = version; Modernizr._prefixes = prefixes; Modernizr.testProp = function (prop) { Modernizr.testAllProps = testPropsAll; Modernizr.testStyles = injectElementWithStyles; return Modernizr; // check for native support // update methods to do something useful /**
var Spinner, (function(root, factory) { /* CommonJS */ /* AMD module */ /* Browser global */ Spinner = factory(); var prefixes = ['webkit', 'Moz', 'ms', 'O'] /* Vendor prefixes / /**
})); /* Bez v1.0.10-g5ae0136
function minMaxLimit (value, min, max) { function readTransform (css) { function readPosition ($el) { function getTranslate (pos, _001) { function getDuration (time) { function numberFromMeasure (value, measure) { function numberFromPercent (value) { function numberFromWhatever (value, whole) { function measureIsValid (value) { function getPosByIndex (index, side, margin, baseIndex) { function getIndexByPos (pos, side, margin, baseIndex) { function bindTransitionEnd ($el) { if (elData.tEnd) return; var el = $el[0], function afterTransition ($el, property, fn, time) { if (elData) {
} function stop ($el, left, _001) {
} function getNumber () { return number; function edgeResistance (pos, edge) { function getProtocol () { function parseHref (href) { function findVideoId (href, forceVideo) { var id, if (href.host.match(/youtube.com/) && href.search) { if ((!id || !type) && forceVideo) { return id ? {id: id, type: type, s: href.search.replace(/^?/, '')} : false; function getVideoThumbs (dataFrame, data, fotorama) { return { function updateData (data, _dataFrame, i, fotorama) {
} function getDataFromHtml ($el) { function getDataFromImg ($img, imgData, checkVideo) {
} function getDimensions ($img, $child, imgData) {
} $el.children().each(function () {
}); return data; function isHidden (el) { function isDetached (el) { function waitFor (test, fn, timeout) { function setHash (hash) { function fit ($el, measuresToFit, method) { if (measures && (!elData.l ||
} return true; function setStyle ($el, style) { function findShadowEdge (pos, min, max) { function getIndexFromHash (hash, data, ok, startindex) { var index; for (var _i = 0, _l = data.length; _i < _l; _i++) {
} return index; function smartClick ($el, fn, _options) { $el.each(function () {
}); function div (classes, child) { ' + (child || '') + ' ';} // Fisher–Yates Shuffle
} return array; function clone (array) { function lockScroll (left, top) { function optionsToLowerCase (options) {
} function getRatio (_ratio) { function stopEvent (e, stopPropagation) { function getDirectionSign (forward) { function slide ($el, options) { if (typeof options.overPos !== 'undefined' && options.overPos !== options.pos) { //console.time('var translate = $.extend'); elData.sliding = true; if (CSS3) { function fade ($el1, $el2, $frames, options, fadeStack, chain) { $el1 = var _$el1 = $el1[0], $frames.removeClass(fadeRearClass + ' ' + fadeFrontClass); $el1 crossfadeFLAG && _$el2 && $el1.fadeTo(0, 0); $el1.fadeTo(crossfadeFLAG ? time : 0, 1, crossfadeFLAG && onEndFn); (_$el1 && crossfadeFLAG) || _$el2 || onEndFn(); function extendEvent (e) { function touch ($el, options) { function onStart (e) {
} function onMove (e) {
} function onEnd (e) {
} function onOtherStart () { function onOtherEnd () { if (MS_POINTER) {
} $el.on('click', 'a', function (e) { return tail; function moveOnTouch ($el, options) { function startTracking (e, noStop) {
} function onStart (e, result) {
} function onMove (e, result) {
} function onEnd (result) {
} tail = $.extend(touch(options.$wrap, { return tail; el[ADD_EVENT_LISTENER] && el[ADD_EVENT_LISTENER](WHEEL, function (e) {
}, false); return tail; var that = this,
toDeactivate[STAGE_FRAME_KEY] = []; $wrap.addClass(CSS3 ? wrapCss3Class : wrapCss2Class); fotoramaData.fotorama = this; function checkForVideo () { function allowKey (key) { function bindGlobalEvents (FLAG) {
} function appendElements (FLAG) {
} function setData () {
} function stageNoMove () {
} function setAutoplayInterval (interval) { /**
|
|
Thank you again. for your time. I hope that I do not have to ask you questions again. I am almost willing to send you a graphical mock up of what I am needing and seeing how much you would charge to do it so it is done right. My javascript knowledge isn’t very good especially when trying to add elements dynamically, and using javascript to create movement. Im trying to learn, but jumping into a project like this and trying to add elements and customize a real professionals work, lol… I have a tough road ahead. Again, I thank you for your time, it is very valuable to me! On Apr 8, 2014, at 5:49 PM, Ferhat notifications@github.com wrote:
|
The element left issue on the previous and next images… using firefox / chrome you can inspect the elements and when you do this, you find that in the div tag or in the code for the previous and next images it shows some css tags, but then there is an added in ‘style’ tag where the code ‘left: -1000px;’ is added for the previous image, if I change this to something like -885px and the next image repeats this except it is a positive number…s o I would change it to something like ‘895px’ and it brings those images into view and puts them right next to the active centered image with about 5px gap between the two. This style tag is not found obviously in the css file.. it is being added via javascript and the numbers given to the ‘left’ tag is also javascript and it is going off of the width of the stage thus giving you a number to push it out of view of the stage. I think. Anyway, I will go through the code and info you sent…thank you again! I hope that I can get this figured out so I do not have to bother you anymore… the help is priceless!! On Apr 8, 2014, at 5:49 PM, Ferhat notifications@github.com wrote:
|
Captions are not correctly hidden if Fotorama is issued to hide captions later on in its life-cycle. See the following JsFiddle:
http://jsfiddle.net/6uw5b/1/
It will only hide the captions of the slides that one has not yet seen. In the Fiddle you see that the captions remain visible for the first two slides. I tried to fix this behaviour but failed to do so.
The text was updated successfully, but these errors were encountered: