fix tests for new heroku stack #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artoonie
force-pushed
the
fix-tests-for-new-stack
branch
2 times, most recently
from
dd17bed to
5f80113
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
artoonie
force-pushed
the
fix-tests-for-new-stack
branch
5 times, most recently
from
055bee4 to
134d4c2
Compare
artoonie
force-pushed
the
fix-tests-for-new-stack
branch
2 times, most recently
from
5c946c9 to
2ae2ece
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 96.70% 96.70%
=======================================
Files 121 121
Lines 5827 5833 +6
=======================================
+ Hits 5635 5641 +6
Misses 192 192
Continue to review full report in Codecov by Sentry.
|
artoonie
force-pushed
the
fix-tests-for-new-stack
branch
2 times, most recently
from
02afb59 to
d9551e1
Compare
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
electionpage/tests.py
Outdated
| for scraper in ScrapableElectionPage.objects.get(slug='cuteslug').listOfScrapers.all(): | ||
| # Wait for the object to be loaded | ||
| self._ensure_eventually_asserts( | ||
| lambda: ScrapableElectionPage.objects.filter(slug='cuteslug').exists() |
There was a problem hiding this comment.
Suggested change
| lambda: ScrapableElectionPage.objects.filter(slug='cuteslug').exists() | |
| ScrapableElectionPage.objects.filter(slug='cuteslug').exists |
Avoid unnecessarily wrapping ScrapableElectionPage.objects.filter.exists in a lambda. More info.
artoonie
force-pushed
the
fix-tests-for-new-stack
branch
from
d9551e1 to
b1438e5
Compare
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our previous Heroku infrastructure, the heroku-20 stack, is deprecated. I'm hoping to upgrade all of RCVis' infrastructure to a supported stack before the election, just in case. I thought this was completed in #513 and #514, but it looks like those upgraded our production stack but not our test infrastructure.
This PR makes all fixes necessary for Heroku CI to pass again on the new stack.