Expose signal for .primaryActionTriggered (on tvOS) #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntly (for example on "clicking" a UIButton) - this exposes a signal for .primaryActionTriggered for tvOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tvOS makes more extensive use of the .primaryActionTriggered UIControl.Event - this exposes a onPrimaryActionTriggered signal for UIControls - currently on tvOS only.
In theory this action can be used on iOS (I believe pressing the done button on the keyboard triggers this event in text fields for example) as well - but it is only available on iOS versions 9.0 and above and the library currently has a minimum iOS version of 8.0. This in theory could be cleaned up (removing the various #if os(tvOS) compiler conditional bits and returning the eventToKey to not use a closure to initialize) by bumping the min os version. Personally I doubt iOS 8 support has any value - but can't make that call for you.