Enhance matrixShortcuts: Optional whitespace trimming & multi-selection support #391
Conversation
Testudinidae
force-pushed
the
feature/matrix-shortcuts-trim-whitespace
branch
2 times, most recently
from
0c271b2 to
82ae879
Compare
Testudinidae
force-pushed
the
feature/matrix-shortcuts-trim-whitespace
branch
from
82ae879 to
4509ae0
Compare
Testudinidae
force-pushed
the
feature/matrix-shortcuts-trim-whitespace
branch
2 times, most recently
from
ea07bcc to
b645757
Compare
Testudinidae
force-pushed
the
feature/matrix-shortcuts-trim-whitespace
branch
from
b645757 to
a9eb98b
Compare
| // Take main cursor since ctx.mode takes the main cursor, weird behaviour is expected with multicursor because of this. | ||
| if (key === "Tab" && view.state.selection.main.empty) { | ||
| view.dispatch(view.state.replaceSelection(" & ")); | ||
| trimWhitespace = settings.matrixShortcutsTrimWhitespace; | ||
|
|
||
| if (key === "Tab") { |
There was a problem hiding this comment.
shifting indentation when selecting something makes more sense then replacing the current selection with a &. Otherwise you can't change the indentation easily but you can replace the current selection by pressing & itself.
couldn't figure out how to review properly, sorry for the possible notifications
There was a problem hiding this comment.
This is a good consideration. I will add && view.state.selection.main.empty back, which means it’s based on the main selection. If there is a selection range in the main, it will indent; if there is no selection in the main, it will replace (regardless of other selections). But I’m also considering whether to change it so that if the selection is the entire line, it will indent, as some IDEs (like VS Code) handle it this way.
|
PR closed as it was replaced by another PR. #394 |
Summary
This PR adds an optional whitespace trimming feature to
matrixShortcuts.Changes
matrixShortcutsTrimWhitespaceThis feature is enabled by default and can be disabled in settings.