feat: Delaying the revealment of concealments #332
Merged
+753
−465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: shunby <25155092+shunby@users.noreply.github.com>
Co-authored-by: shunby <25155092+shunby@users.noreply.github.com>
Co-authored-by: shunby <25155092+shunby@users.noreply.github.com>
Co-authored-by: shunby <25155092+shunby@users.noreply.github.com>
Prevents flickering of math expressions when the cursor is placed between the braces of `\frac{}{}`
|
Thanks for the PR! I'll take a look soon. |
|
This works very well. Thanks! |
|
This is awesome, thanks! All of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #283
Key points of the implementation
We introduced 3 new types:
Replacement,ConcealSpec, andConcealment. It's a bit confusing, butReplacementis equivalent toConcealmentin the previous code, while the newConcealmentnow refers to something different.ConcealSpec: array ofReplacement. Replacements in the same conceal spec are enabled or disables simultaneously. This layer is necessary due to LaTeX commands such as\fracand\set.Concealment:ConcealSpecwith additional context. The decorations and atomic ranges are built from a list ofConcealmentobjects.The
concealfunction collects conceal specs. Note that it does not rely on the mouse position or whether the mouse is down. The conceal specs collected are converted intoConcealmentobjects using information such as the previousConcealmentobjects. At this time, the ones that should be revealed after a delay are passed to the debouncer.