Support custom conceal maps

[llakala]

Description of the Problem

Currently, all of the conceal maps are hardcoded at https://github.com/artisticat1/obsidian-latex-suite/blob/418b355079ad03d2b6d84362df20fb31ca96aa52/src/editor_extensions/conceal_maps.ts. If you add custom Latex functions, which you can do via other plugins, they won't be concealed, and appear like this:

Description of the Solution

Obviously, custom commands like this shouldn't be added to the default. Therefore, we need a way to add them in after-the-fact. I propose an option be added, similar to the one seen for changing snippet variables. You could even make it possible to remove default conceals, by making the default value of the conceal option the current default.

To clarify what I mean, here's how the default could look if this was implemented:

{
	"${CMD_SYMBOLS}": {
        "aleph": "ℵ",
	    "amalg": "∐",
        // etc
	"${OPERATORS}": [
		"arcsin",
		"arccos",
		"arctan",
		"sinh",
		// etc
	],
	"${OPERATORS}": {
		"{1}{2}": "½",
		"{1}{3}": "⅓",
		"{2}{3}": "⅔",
        // etc
};

And so on, with the ability to customize each element within the linked file. I think you should be able to customize each existing variable in the file, which would give you this list:

• symbols
• operators
• fractions
• greek
• super
• sub
• bar
• dot
• hat
• brackets
• mathbb
• mathscrcal
• mathfrak

I'll admit some of these make less sense than others when it comes to customizing them. But I think it makes more sense to support customizing everything, than only customizing certain fields that we arbitrarily decide are worth it, especially since simply reading from more variables would be fairly trivial.

Additional

I can't think of any other options that accomplish the same goal. You could set up lots of different options for each of the elements in the file, rather than one input with variables. I think that's silly, though. Using variable keeps the code light.

If nobody gets around to it, I can make a PR for this in a few weeks when I have time. If you want to beat me to it, feel free!

[superle3]

You mean https://github.com/RyotaUshio/obsidian-mathjax-preamble-manager this right, cause I am getting an 404.

I propose keeping the same format of conceal_maps.ts and just import those variables if they exist. That would give the user more options how to structure their file settings, though nested files wouldn't update automatically.

Also ideally all of mathjax symbols should be added, but since that is a lot, atleast the basemapping and https://github.com/mathjax/MathJax-src/blob/844ad7513005fa096a07d2468bf59c7f6a6c3a50/ts/input/tex/ams/AmsMappings.ts should be included by default.

\subsetneq doesn't conceal for example

[llakala]

You mean RyotaUshio/obsidian-mathjax-preamble-manager this right, cause I am getting an 404.

Yes, that's the one, sorry for the broken link.

I propose keeping the same format of conceal_maps.ts and just import those variables if they exist. That would give the user more options how to structure their file settings, though nested files wouldn't update automatically.

Do you mean:

if custom_maps_defined; then
  use_custom_maps
else
  use_default_maps

I understand why you'd do this, but my problem is that it becomes less clear to that the variable replaces the default conceal maps, and doesn't just append to it. A user might expect that they'd be able to simply add something custom, but then find that all the default conceal maps no longer work. If the variable isn't set by default, it's also harder to find out that the functionality exists in the first place.

[superle3]

Oh i read the proposal wrong. Still want the format

export const cmd_symbols = {}

export const operators = []

export const fractions = {}

but you can indeed also merge the default with the user defined maps where the user defined maps take priority.
How would this work for the arrays though.

Also you would do that for each concealment type so not all concealments would be removed if you only redefine one.
And its not that odd of an behaviour. The same thing happens with snippets and symbols.

edit:
Not every "package" at mathjax seems to have a mappings.ts. not sure what they do then but of the mappings below
BaseMappings.ts > AmsMappings.ts > MathtoolsMapping.ts for priority I think. Physics and Bussproofs are not included in obsidian I think.
AmsCdMappings.ts BaseMappings.ts BussproofsMappings.ts NewcommandMappings.ts TextcompMappings.ts
AmsMappings.ts BraketMappings.ts MathtoolsMappings.ts PhysicsMappings.ts TextMacrosMappings.ts

[superle3]

duplicates have been made at #287, #242, #124, but since they are not active lets continue here.

Also there is something wrong with the mapping. At #386 \Subset doesn't get concealed correctly.

edit: almost fixed it. the thing that won't get concealed is

$$\def\föö{hello world}\fööa$$

and yes this does expand to hello worlda which is stupid.