Updates to support Poetry v2#30
Open
nathanielheitsch wants to merge 2 commits intoartisanofcode:mainfrom
Open
Conversation
hasier
reviewed
Dec 8, 2025
| cleo.events.console_events.COMMAND, | ||
| self.event_listener, | ||
| ) | ||
| if application.event_dispatcher is not None: |
There was a problem hiding this comment.
@danielknell even if this should never be None due to this call, BaseApplication types it as nullable, so I guess this check is not incorrect? Would you rather invert the check and raise an exception instead, in case it is ever not set, to prevent this from silently failing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates poetry constraint and min Python constraint (they dropped 3.8). Updates some type imports.
Motivation and Context
Couldn't use with Poetry v2
How Has This Been Tested?
Runs with poetry v2
Types of changes
Checklist: