Drop full aws sdk #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasadrianof
requested changes
Mar 31, 2023
There was a problem hiding this comment.
Dang, this is a really nice work, I love it 🥳 .
I really liked how we were able to move away from ramda and use the new AWS SDK with TS with no other extra dependencies. Nice addition with the eslint plugin too 👏🏽 .
I have a few suggestions, but overall this looks great!
|
@lucasadrianof All comments addressed, feel free to check again. |
lucasadrianof
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://github.com/articulate/identity/issues/947
Review steps
Described in this PR https://github.com/articulate/heyokra/pull/393